rhtyd commented on a change in pull request #2290: WIP: add track id to async
api calls
URL: https://github.com/apache/cloudstack/pull/2290#discussion_r148743240
##########
File path: server/src/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4600,14 +4602,18 @@ public UserVm createVirtualMachine(DeployVMCmd cmd)
throws InsufficientCapacityE
DataCenter zone = _entityMgr.findById(DataCenter.class, zoneId);
if (zone == null) {
- throw new InvalidParameterValueException("Unable to find zone by
id=" + zoneId);
+ CloudRuntimeException ex = new
InvalidParameterValueException("Unable to find zone by id=" + zoneId);
Review comment:
Does it make sense to instead, get/set the context/jobid in the exception
constructor if CallContext is available to it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
