rafaelweingartner commented on issue #1278: CLOUDSTACK-9198: Virtual router 
gets deployed in disabled Pod
URL: https://github.com/apache/cloudstack/pull/1278#issuecomment-352689132
 
 
   @rhtyd sorry. Yesterday I was not able to return to this issue.
   
   That is what I thought first. However, there is something I do not 
understand here. This is what Gabriel, Nicolas and I tried to explain here.
   
   Take a look at line 336 and 516 where the variables `callerUser` and 
`caller` are used as parameters; if the decision to place or not a VR in a POD 
that is disabled is based on those variables, I would expect them to be used in 
`startVirtualRouter` method, right?
   
   So, if you take a look at ` startVirtualRouter ` method, you are going to 
see that those variables are not used there. They are simply passed as 
parameters to another method, which is called `start`. The issue is the 
following. Variables `callerUser` and `caller` are not used in `start` method 
either. They are also not sent to any other method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to