marcaurele commented on a change in pull request #837: CLOUDSTACK-8855 Improve
Error Message for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/837#discussion_r159381276
##########
File path:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
##########
@@ -986,33 +986,28 @@ public Answer easySend(final Long hostId, final Command
cmd) {
}
@Override
- public boolean reconnect(final long hostId) {
+ public void reconnect(final long hostId) throws CloudRuntimeException,
AgentUnavailableException{
HostVO host;
host = _hostDao.findById(hostId);
if (host == null || host.getRemoved() != null) {
- s_logger.warn("Unable to find host " + hostId);
- return false;
+ throw new CloudRuntimeException("Unable to find host " + hostId);
}
if (host.getStatus() == Status.Disconnected) {
- s_logger.info("Host is already disconnected, no work to be done");
- return true;
+ throw new CloudRuntimeException("Host is already disconnected, no
work to be done");
Review comment:
It looks pretty wrong to throw an exception when no action should be taken.
What are the logic to throw an exception here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
