marcaurele commented on a change in pull request #2381: CLOUDSTACK-10117 
Account ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159626258
 
 

 ##########
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java
 ##########
 @@ -31,18 +34,27 @@
     @Param(description = "port")
     private int port;
 
+    @SerializedName("domain_id")
 
 Review comment:
   @DaanHoogland where do you see mixed convention (on the API)? I can see the 
`domain_id` when it's refering a database column, but not in the API 
command/responses so far.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to