DaanHoogland commented on a change in pull request #2418: CLOUDSTACK-10242:
Properly parse incoming rules to Sec Group
URL: https://github.com/apache/cloudstack/pull/2418#discussion_r162903882
##########
File path: scripts/vm/network/security_group.py
##########
@@ -951,16 +951,15 @@ def parse_network_rules(rules):
if rules is None or len(rules) == 0:
return ret
- lines = rules.split(';')[:-1]
+ lines = rules.split('NEXT;')[:-1]
Review comment:
I think this extremely ugly solution is acceptable but i see a possible
problem with the preceeding , it spells ',NEXT;' could it be ',NEXT,', instead?
and if so, why not just ','? (read at your own risk)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
