wido opened a new pull request #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421 This might (and does block) in certain situations on the VR as also explained in the Python documentation: https://docs.python.org/2/library/subprocess.html#subprocess.Popen.wait Warning This will deadlock when using stdout=PIPE and/or stderr=PIPE and the child process generates enough output to a pipe such that it blocks waiting for the OS pipe buffer to accept more data. Use communicate() to avoid that. Using the check_output function handles most of this for us and also provides better error handling. Signed-off-by: Wido den Hollander <w...@widodh.nl>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
