rafaelweingartner commented on a change in pull request #2567: [Vmware] Fix for
OVF parsing error
URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181162268
##########
File path: api/src/com/cloud/agent/api/storage/OVFHelper.java
##########
@@ -113,7 +113,7 @@ public static Long getDiskVirtualSize(Long capacity,
String allocationUnits, Str
String allocationUnits =
disk.getAttribute("ovf:capacityAllocationUnits");
od._diskId = disk.getAttribute("ovf:diskId");
od._fileRef = disk.getAttribute("ovf:fileRef");
- od._populatedSize =
Long.parseLong(disk.getAttribute("ovf:populatedSize") == null ? "0" :
disk.getAttribute("ovf:populatedSize"));
+ od._populatedSize =
Long.parseLong(StringUtils.isBlank(disk.getAttribute("ovf:populatedSize")) ?
"0" : disk.getAttribute("ovf:populatedSize"));
Review comment:
Why not use `org.apache.commons.lang3.math.NumberUtils.toLong(String)`
instead?
Then, you do not even need this inline IF
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
