lujiefsi commented on a change in pull request #2573: Cloudstack 10356
URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181781752
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -2337,8 +2337,9 @@ public int compare(final DiskTO arg0, final DiskTO arg1)
{
disk.setCacheMode(DiskDef.DiskCacheMode.valueOf(volumeObjectTO.getCacheMode().toString().toUpperCase()));
}
}
-
- vm.getDevices().addDevice(disk);
+ if (vm.getDevices() != null) {
Review comment:
Yes, an exception is better, but checker should need shift to an earlier
position, because there exist another three "vm.getDevices;" in the flowing
code . Move to line 2340 is suitable, code can be
if (vm.getDevices() == null){
throw new CloudRuntimeException(There is no devices for " + vm);
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
