rafaelweingartner commented on a change in pull request #2627: Catch error in packagin script and fail the build URL: https://github.com/apache/cloudstack/pull/2627#discussion_r186713637
########## File path: packaging/package.sh ########## @@ -162,11 +162,16 @@ function packaging() { cp "$PWD/$DISTRO/cloud.spec" "$RPMDIR/SPECS" (cd "$RPMDIR"; rpmbuild --define "_topdir ${RPMDIR}" "${DEFVER}" "${DEFFULLVER}" "${DEFREL}" ${DEFPRE+"$DEFPRE"} ${DEFOSSNOSS+"$DEFOSSNOSS"} ${DEFSIM+"$DEFSIM"} -bb SPECS/cloud.spec) - (cd $PWD/../; git reset --hard) if [ $? -ne 0 ]; then + if [ "$USE_TIMESTAMP" == "true" ]; then Review comment: What is the default of `USE_TIMESTAMP`? `false`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services