DaanHoogland commented on a change in pull request #2636: Fix limitation on tag
matching in 'migrateVolume' with disk offering replacement
URL: https://github.com/apache/cloudstack/pull/2636#discussion_r187577573
##########
File path: server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java
##########
@@ -580,9 +580,86 @@ public void
validateConditionsToReplaceDiskOfferingOfVolumeTestEverythingWorking
inOrder.verify(storagePoolMock).isLocal();
inOrder.verify(newDiskOfferingMock, times(0)).isShared();
inOrder.verify(volumeApiServiceImpl).getStoragePoolTags(storagePoolMock);
- inOrder.verify(newDiskOfferingMock).getTags();
inOrder.verify(volumeVOMock).getSize();
inOrder.verify(newDiskOfferingMock).getDiskSize();
}
+
+ @Test
+ public void
doesTargetStorageSupportNewDiskOfferingTestDiskOfferingMoreTagsThanStorageTags()
{
Review comment:
wow, how java of you @rafaelweingartner , can you translate this name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
