rafaelweingartner commented on a change in pull request #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters URL: https://github.com/apache/cloudstack/pull/2091#discussion_r187587997
########## File path: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java ########## @@ -4905,7 +4924,7 @@ protected Answer execute(UnregisterVMCommand cmd) { VirtualMachineFileLayoutEx vmFileLayout = vmMo.getFileLayout(); context.getService().unregisterVM(vmMo.getMor()); if (cmd.getCleanupVmFiles()) { - deleteUnregisteredVmFiles(vmFileLayout, dataCenterMo, false); + deleteUnregisteredVmFiles(vmFileLayout, dataCenterMo, false, null); Review comment: So, if there is an exception, you do delete the files, even if you shouldn't? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services