rafaelweingartner commented on a change in pull request #2503: Support multiple volume access groups per compute cluster URL: https://github.com/apache/cloudstack/pull/2503#discussion_r187593250
########## File path: plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java ########## @@ -300,7 +311,7 @@ public static String getValue(String keyToMatch, String url, boolean throwExcept } public static String getSolidFireAccountName(String csAccountUuid, long csAccountId) { - return "CloudStack_" + csAccountUuid + "_" + csAccountId; + return SF_CS_ACCOUNT_PREFIX + csAccountUuid + "_" + csAccountId; Review comment: Thinking about the `String.format` method, where you send the "pattern" and then the parameters to create a new String. I do believe that the `format` as a prefix looks good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services