DaanHoogland commented on a change in pull request #2653: Generate MAC address
if the MAC in command addNicToVirtualMachine is invalid
URL: https://github.com/apache/cloudstack/pull/2653#discussion_r189795031
##########
File path: server/src/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -1228,6 +1230,19 @@ public UserVm addNicToVirtualMachine(AddNicToVMCmd cmd)
throws InvalidParameterV
return _vmDao.findById(vmInstance.getId());
}
+ /**
+ * If the given MAC address is invalid it replaces the given MAC with the
next available MAC address
+ */
+ protected String validateOrReplaceMacAddress(String macAddress, long
networkId) {
+ if (!NetUtils.isValidMac(macAddress)) {
Review comment:
I am having second thoughts, when a user entered a MAC address but made a
typo, we are now creating a new address for them, uncalled for. shouldn't we
have refused and thrown some horrible thing instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
