rafaelweingartner commented on a change in pull request #2653: Generate MAC
address if the MAC in command addNicToVirtualMachine is invalid
URL: https://github.com/apache/cloudstack/pull/2653#discussion_r189836738
##########
File path: server/src/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -1228,6 +1230,19 @@ public UserVm addNicToVirtualMachine(AddNicToVMCmd cmd)
throws InvalidParameterV
return _vmDao.findById(vmInstance.getId());
}
+ /**
+ * If the given MAC address is invalid it replaces the given MAC with the
next available MAC address
+ */
+ protected String validateOrReplaceMacAddress(String macAddress, long
networkId) {
+ if (!NetUtils.isValidMac(macAddress)) {
Review comment:
I think we should only generate a MAC address if the value entered by the
user is null. All other combinations (invalid, empty, blank and so on) should
return an invalid parameter value exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
