DaanHoogland commented on a change in pull request #2659: removed unused code
in snapshotDao
URL: https://github.com/apache/cloudstack/pull/2659#discussion_r189864415
##########
File path:
engine/schema/src/main/java/com/cloud/storage/dao/SnapshotDaoImpl.java
##########
@@ -253,41 +202,6 @@ public long getLastSnapshot(long volumeId, DataStoreRole
role) {
return 0;
}
- @Override
- public long updateSnapshotVersion(long volumeId, String from, String to) {
- TransactionLegacy txn = TransactionLegacy.currentTxn();
- PreparedStatement pstmt = null;
- String sql = UPDATE_SNAPSHOT_VERSION;
- try {
- pstmt = txn.prepareAutoCloseStatement(sql);
- pstmt.setString(1, to);
- pstmt.setLong(2, volumeId);
- pstmt.setString(3, from);
- pstmt.executeUpdate();
- return 1;
- } catch (Exception ex) {
- s_logger.error("error getting last snapshot", ex);
- }
- return 0;
- }
-
- @Override
- public long updateSnapshotSecHost(long dcId, long secHostId) {
- TransactionLegacy txn = TransactionLegacy.currentTxn();
- PreparedStatement pstmt = null;
- String sql = UPDATE_SECHOST_ID;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
