rafaelweingartner commented on a change in pull request #2660: Macaddresses
URL: https://github.com/apache/cloudstack/pull/2660#discussion_r190194554
##########
File path: utils/src/test/java/com/cloud/utils/net/MacAddressTest.java
##########
@@ -51,10 +52,11 @@ public final void testMacAddressToLong() throws Exception {
// TODO public final void testToString() throws Exception {
// TODO public final void testGetMacAddress() throws Exception {
// TODO public final void testParse() throws Exception {
- // TODO public final void testMain() throws Exception {
- // TODO public final void testParseLong() throws Exception {
- // TODO public final void testParseInt() throws Exception {
- // TODO public final void testParseShort() throws Exception {
- // TODO public final void testParseByte() throws Exception {
+ public static void main(String[] args) {
Review comment:
Now I think I understood what you meant, but still I am skeptical with code
that we might leave behind. This can be used as an excuse to maintain non-used
code that we constantly see around. In my perspective a developer should be
able to find tool to validate/execute small checks instead of building them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
