ernjvr commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202329269
########## File path: framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java ########## @@ -1049,8 +1054,8 @@ public void doInTransactionWithoutResult(TransactionStatus status) { } } } - List<SnapshotDetailsVO> snapshotList = _snapshotDetailsDao.findDetails(AsyncJob.Constants.MS_ID, Long.toString(msid), false); - for (SnapshotDetailsVO snapshotDetailsVO : snapshotList) { + final List<SnapshotDetailsVO> snapshotList = _snapshotDetailsDao.findDetails(AsyncJob.Constants.MS_ID, Long.toString(msid), false); Review comment: Best practice is to make objects immutable and it makes the code safer and more predictable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services