rafaelweingartner commented on a change in pull request #2773:
CLOUDSTACK-10328: Add Secondary IPv6 address through API
URL: https://github.com/apache/cloudstack/pull/2773#discussion_r205415478
##########
File path: api/src/main/java/com/cloud/network/NetworkService.java
##########
@@ -189,12 +181,16 @@ Network createPrivateNetwork(String networkName, String
displayText, long physic
String netmask, long networkOwnerId, Long vpcId, Boolean sourceNat,
Long networkOfferingId) throws ResourceAllocationException,
ConcurrentOperationException,
InsufficientCapacityException;
- /* Requests an IP address for the guest nic */
- NicSecondaryIp allocateSecondaryGuestIP(long nicId, String ipaddress)
throws InsufficientAddressCapacityException;
+ /**
+ * Requests an IP address for the guest nic
+ */
+ NicSecondaryIp allocateSecondaryGuestIP(long nicId, IpAddresses
requestedIpPair) throws InsufficientAddressCapacityException;
boolean releaseSecondaryIpFromNic(long ipAddressId);
- /* lists the nic informaton */
+ /**
+ * lists the nic informaton
Review comment:
NIC instead of nic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
