[GitHub] rhtyd closed pull request #2788: data table header cursor type and title

[GitBox]

rhtyd closed pull request #2788: data table header cursor type and title
URL: https://github.com/apache/cloudstack/pull/2788
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ui/css/cloudstack3.css b/ui/css/cloudstack3.css
index d68b4f8c3cf..b15b5163a31 100644
--- a/ui/css/cloudstack3.css
+++ b/ui/css/cloudstack3.css
@@ -125,6 +125,7 @@ table thead th {
   text-shadow: 0px 1px 1px #FFFFFF;
   font-weight: bold;
   white-space: nowrap;
+  cursor: pointer;
 }
 
 table thead th.sorted {
@@ -243,10 +244,7 @@ table thead th.quick-view {
   height: 14px !important;
   text-indent: 2px;
   white-space: nowrap;
-}
-
-table tbody td.quick-view {
-  cursor: pointer;
+  cursor: default;
 }
 
 table tbody td.quick-view .icon {
diff --git a/ui/scripts/ui/widgets/listView.js 
b/ui/scripts/ui/widgets/listView.js
index fed61943861..688b77df6b0 100644
--- a/ui/scripts/ui/widgets/listView.js
+++ b/ui/scripts/ui/widgets/listView.js
@@ -780,7 +780,7 @@
 
         var addColumnToTr = function($tr, key, colspan, label, 
needsCollapsibleColumn) {
             var trText = _l(label);
-            var $th = $('<th>').addClass(key).attr('colspan', 
colspan).appendTo($tr);
+            var $th = $('<th>').addClass(key).attr('colspan', 
colspan).attr('title', trText).appendTo($tr);
             if ($th.index()) $th.addClass('reduced-hide');
             $th.css({'border-right': '1px solid #C6C3C3', 'border-left': '1px 
solid #C6C3C3'});
             if (needsCollapsibleColumn) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services