rhtyd commented on a change in pull request #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#discussion_r224387457
########## File path: plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java ########## @@ -223,7 +223,9 @@ private ApiDiscoveryResponse getCmdRequestMap(Class<?> cmdClass, APICommand apiC for (APIChecker apiChecker : _apiAccessCheckers) { try { - apiChecker.checkAccess(user, name); + if (!"ApiRateLimitServiceImpl".equals(apiChecker.getName())) { Review comment: you can use something like this.class.getName() or the .getName()... instead of the hard coded string comparison. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services