rafaelweingartner commented on a change in pull request #2900: network: Allow
ability to disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225154560
##########
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2860,7 +2860,7 @@ public boolean restartNetwork(final Long networkId,
final Account callerAccount,
s_logger.debug("Implementing the network " + network + " elements and
resources as a part of network restart without cleanup");
try {
implementNetworkElementsAndResources(dest, context, network,
offering);
- setRestartRequired(network, true);
+ setRestartRequired(network, false);
Review comment:
this will the opposite? I mean, if I restart with cleanup, will not this
cause the flag to always be false? Or, is the flag from the command captured
and used somewhere else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
