rhtyd commented on a change in pull request #2900: network: Allow ability to
disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225965883
##########
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2927,6 +2927,14 @@ public boolean areRoutersRunning(final List<? extends
VirtualRouter> routers) {
* @throws InsufficientCapacityException
*/
private boolean rollingRestartRouters(final NetworkVO network, final
NetworkOffering offering, final DeployDestination dest, final
ReservationContext context) throws ResourceUnavailableException,
ConcurrentOperationException, InsufficientCapacityException {
+ if (!NetworkOrchestrationService.RollingRestartEnabled.value()) {
Review comment:
If rolling restart is false (disabled), then legacy restart behaviour will
be used, which first shutsdown and destroys VRs before starting new ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
