[GitHub] rafaelweingartner commented on a change in pull request #3000: CLOUDSTACK-2998: Added two more device name patterns to valid bridge slaves (lo* and dummy*)

[GitBox]

rafaelweingartner commented on a change in pull request #3000: CLOUDSTACK-2998: 
Added two more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r231482349
 
 

 ##########
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##########
 @@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
         return "";
     }
 
-    String [] _ifNamePatterns = {
+    static String [] ifNamePatterns = {
 
 Review comment:
   @bwsw, what if we invert the logic?
   
   Let me explain myself. We already have 13! (that is too much; it is indeed a 
nice magic number though) patterns to tell which ones are the valid physical 
interfaces names that we should look for. However, we can do the opposite. So, 
we can say that the physical interface is anything that is not “^vnet*”. Then, 
if I decide to use a physical interface named “XYZ”, I will not need to change 
anything else in the code.
   
   What do you think?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services