GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live
migration with ROOT volume on file storage type
URL: https://github.com/apache/cloudstack/pull/2997#discussion_r241456219
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/MigrateKVMAsync.java
##########
@@ -36,6 +36,36 @@
private boolean migrateStorage;
private boolean autoConvergence;
+ /**
+ * Do not pause the domain during migration. The domain's memory will be
transferred to the destination host while the domain is running. The migration
may never converge if the domain is changing its memory faster then it can be
transferred. The domain can be manually paused anytime during migration using
virDomainSuspend.
+ * @value 1
+ * @see Libvirt <a
href="https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainMigrateFlags";>virDomainMigrateFlags</a>
documentation
+ */
+ private static final long VIR_MIGRATE_LIVE = 1l;
Review comment:
The variable (`VIR_MIGRATE_LIVE`) is a primitive long; the JVM would make
the Long into a primitive long via the auto unboxing process. I don't think
that making it Long would make much a difference.
Are you talking about this recomendation?
> The suffix L is preferred, because the letter l (ell) is often hard to
distinguish from the digit 1 (one).
I don't think that it would improve much the readability of the code here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
