rafaelweingartner commented on a change in pull request #3122: Add back ability
to disable backup of snapshot to secondary
URL: https://github.com/apache/cloudstack/pull/3122#discussion_r248484841
##########
File path:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
##########
@@ -149,6 +149,17 @@ public long getPhysicalSize() {
return physicalSize;
}
+ @Override
+ public void markBackedUp() throws CloudRuntimeException{
+ try {
+ processEvent(Event.OperationNotPerformed);
+ } catch (NoTransitionException ex) {
+ s_logger.error("no transition error: ", ex);
+ throw new CloudRuntimeException("Error marking snapshot backed up:
" +
Review comment:
Can you maintain the history of the stack of the exception that is re-thrown
here?
I mean, it is a matter of using `throw new CloudRuntimeException(<message>,
<exception>)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
