DaanHoogland commented on a change in pull request #3251: [WIP DO NOT MERGE]
Add local ISO upload via UI
URL: https://github.com/apache/cloudstack/pull/3251#discussion_r270848283
##########
File path: server/src/main/java/com/cloud/template/TemplateAdapterBase.java
##########
@@ -284,35 +285,62 @@ public TemplateProfile prepare(RegisterTemplateCmd cmd)
throws ResourceAllocatio
}
- @Override
- public TemplateProfile prepare(GetUploadParamsForTemplateCmd cmd) throws
ResourceAllocationException {
+ /**
+ * Prepare upload parameters internal method for templates and ISOs local
upload
+ */
+ private TemplateProfile prepareUploadParamsInternal(boolean isIso, long
userId, String name, String displayText,
Review comment:
can't we use a common parameter object to both commands instead of this
insanely long parameterlist(, please)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
