[GitHub] [cloudstack] shwstppr opened a new pull request #3257: server: fix for vm snapshot search (#3208)

[GitBox]

shwstppr opened a new pull request #3257: server: fix for vm snapshot search 
(#3208)
URL: https://github.com/apache/cloudstack/pull/3257
 
 
   ## Description
   Fixes #3208 
   
   Using db column instead of VO variable name was causing issue with SQL 
select statement.
   This PR fixes the problem by using VO variable for adding conditional.
   Additionally in UI **listAll** parameter was being sent twice in the 
listVMSnapshot API call. It is fixed with this PR.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Original behavior giving error,
   ![Screenshot from 2019-04-03 
13-06-09](https://user-images.githubusercontent.com/153340/55461272-b6093400-5611-11e9-99bf-6353431f80d1.png)
   
   With changes,
   ![Screenshot from 2019-04-03 
13-09-04](https://user-images.githubusercontent.com/153340/55461317-c9b49a80-5611-11e9-9ce2-69e0174756ea.png)
   ![Screenshot from 2019-04-03 
13-08-18](https://user-images.githubusercontent.com/153340/55461321-cb7e5e00-5611-11e9-92b1-db225d8cc69f.png)
   
   ## How Has This Been Tested?
   From UI and cmk
   
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services