anuragaw commented on a change in pull request #3258:  [WIP DO NOT MERGE] 
Configure hiding table columns through config.js file
URL: https://github.com/apache/cloudstack/pull/3258#discussion_r273373114
 
 

 ##########
 File path: ui/scripts/ui/widgets/listView.js
 ##########
 @@ -860,6 +860,8 @@
         if (groupableColumns) {
             
$tr.addClass('groupable-header-columns').addClass('groupable-header');
             $.each(fields, function(key) {
 
 Review comment:
   This was broken in existing code and needed fixing. If an upper field is 
hidden we must not draw it's containing columns.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to