rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#discussion_r276172133
########## File path: api/src/com/cloud/storage/Volume.java ########## @@ -52,7 +52,8 @@ UploadInProgress("Volume upload is in progress"), UploadError("Volume upload encountered some error"), UploadAbandoned("Volume upload is abandoned since the upload was never initiated within a specificed time"), - Attaching("The volume is attaching to a VM"); + AttachingFromReady("The volume is attaching to a VM from Ready State"), + AttachingFromAllocated("The volume is attaching to a VM from Allocated State"); Review comment: I think we can still fix the issue without introducing a new state. All we're saying is to allow volumes's attaching state whether their previous state is Ready or Allocated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services