syed commented on a change in pull request #3282: [WIP DO NOT MERGE] Fix slow vm creation when large sf snapshot count URL: https://github.com/apache/cloudstack/pull/3282#discussion_r278754030
########## File path: engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDao.java ########## @@ -30,6 +30,8 @@ List<SnapshotDataStoreVO> listByStoreId(long id, DataStoreRole role); + List<SnapshotDataStoreVO> listByStoreIdInReadyState(long id); Review comment: Both track different things. `SnapshotState` is more for the end snapshot object whereas `ObjectInDataStore` tracks the status of the snapshot on a particular storage pool ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services