DaanHoogland commented on a change in pull request #3293: Limit selecting of 
secondary storage with 90% utilization
URL: https://github.com/apache/cloudstack/pull/3293#discussion_r279156816
 
 

 ##########
 File path: 
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java
 ##########
 @@ -157,6 +157,7 @@ public DataStore getImageStore(List<DataStore> 
imageStores) {
                 }
             }
         }
-        return imageStores.get(0);
+        s_logger.debug("Can't find staging storage in zone with less than 90% 
usage");
 
 Review comment:
   isn't this threshold value meant to be configurable? change makes sense if 
not!
   /cc @DagSonsteboSB @rhtyd  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to