GabrielBrascher commented on a change in pull request #3312: 'sed -i' need postfix on mac URL: https://github.com/apache/cloudstack/pull/3312#discussion_r285273501
########## File path: tools/apidoc/build-apidoc.sh ########## @@ -61,8 +60,8 @@ set -e cp "$thisdir"/*.java . cp "$thisdir"/*.xsl . sed -e 's,%API_HEADER%,All APIs,g' "$thisdir/generatetoc_header.xsl" >generatetoc.xsl - sed -i "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatetoc.xsl - sed -i "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatecommands.xsl + sed -i .bak "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatetoc.xsl Review comment: @DaanHoogland @rafaelweingartner A (ugly) solution is running the command with the -e and move the new file to the old one: `sed -e "s/%ACS_RELEASE%/${ACS_RELEASE}/g" newGeneratetoc.xsl && mv newGeneratetoc.xsl generatetoc.xsl;` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services