nhayfield opened a new issue #3349: Validation on Router Advertisement for Firewall Rules URL: https://github.com/apache/cloudstack/issues/3349 ##### ISSUE TYPE * Bug Report ##### COMPONENT NAME Firewall Rules for VMs ~~~ ##### CLOUDSTACK VERSION Latest ~~~ ~~~ ##### CONFIGURATION N/A ##### OS / ENVIRONMENT N/A ##### SUMMARY https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java/#LC527 The code on this page uses the function NetUtils.validateIcmpCode to validate that the code is between 0-15. However there is a case in our system where an apparently valid code is 16. If you look at the spec for Type 9 Router Advertisement: https://www.iana.org/assignments/icmp-parameters/icmp-parameters.xhtml#icmp-parameters-codes-9/#table-icmp-parameters-ext-classes The valid codes are 0 and 16. Not sure if this is intended to eliminate this option or not.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
