DaanHoogland commented on a change in pull request #3215: [WIP DO NOT MERGE] storage: post process locally uploaded multi-disk ova template URL: https://github.com/apache/cloudstack/pull/3215#discussion_r287295828
########## File path: server/src/main/java/com/cloud/storage/ImageStoreUploadMonitorImpl.java ########## @@ -395,6 +404,20 @@ public void doInTransactionWithoutResult(TransactionStatus status) { VMTemplateVO templateUpdate = _templateDao.createForUpdate(); templateUpdate.setSize(answer.getVirtualSize()); _templateDao.update(tmpTemplate.getId(), templateUpdate); + // For multi-disk OVA, check and create data disk templates Review comment: i see the same commen t in three places. Is this eligible for a refactor as overloaded method? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services