richardlawley opened a new pull request #3361: Fix 4.11 VR Issues with Multiple Public Subnets URL: https://github.com/apache/cloudstack/pull/3361 ## Description <!--- Describe your changes in detail --> This PR resolves 2 issues related to Virtual Routers with multiple public interfaces, and works around a third. 1. Fixes: #3353 - Adds missing throw routes for eth0/eth1 to eth3+ when there are >1 public IPs 2. Fixes: #3168 - Incorrect marks set on some static NAT rules (some code references were changed from `hex(int(interfacenum))` to `hex(100 + int(interfacenum))` - this change just adds the remaining ones 3. Works around #3352 - Sends Gratuitous ARP messages when a HA VR becomes master to work around the problem of the MAC address being different between HA VRs. If that issue is fixed properly (i.e. a database entry for the subsequent interfaces so they can be static) then this is unnecessary, though should not cause any problems. <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> These changes form part of the ISO we are deploying in production. Upon upgrading from 4.8 to 4.11.2, we ran into the issues described above and fixed them in a scripts ISO we have customised for our deployment. Our deployments are all advanced networking/non-VPC. These changes are mostly within conditionals which should stop them making any difference to a "standard" advanced VR (i.e. single public interface). <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
