pbankonier edited a comment on issue #3294: Set default service offering over 
api and ui
URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498716577
 
 
   @svenvogel @DennisKonrad @rafaelweingartner @PaulAngus I looked into the 
code for the global default offering settings and found that the only place 
where this global config variables are used is in the ManagerImpls for the 
different offering types.
   The global settings are just used to check if there is already an offering 
with the given id existing in the database. There is no code which sets an 
offering to a default one with this configs. So maybe this was implemented to 
prevent that a new default offering was created at the start of the application 
before the uniquenames were introduced.
   
   There is no need for a migration path with this PR. There will be no changes 
which will break existing functionality.
   After my analysis the global default settings do nothing in the current 
state of the software and we can remove them.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to