rhtyd commented on a change in pull request #3075: KVM: Prevent regenerating
keystore on provisionCertificate API
URL: https://github.com/apache/cloudstack/pull/3075#discussion_r290569265
##########
File path: scripts/util/keystore-cert-import
##########
@@ -38,9 +38,6 @@ if [ -z "${KS_PASS// }" ]; then
exit 1
fi
-# Use a new keystore file
-NEW_KS_FILE="$KS_FILE.new"
Review comment:
The script was create to be idempotent for jks creation and cert import.
I'll have to test concurrent cases and see if this script would pass/fail. I'll
test and review today and keep you posted @nvazquez thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
