DaanHoogland commented on a change in pull request #3378: project id added in
test
URL: https://github.com/apache/cloudstack/pull/3378#discussion_r293387009
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -646,7 +646,12 @@
Ternary<Long, Boolean, ListProjectResourcesCriteria>
domainIdRecursiveListProject = new Ternary<Long, Boolean,
ListProjectResourcesCriteria>(cmd.getDomainId(), cmd.isRecursive(), null);
- _accountMgr.buildACLSearchParameters(caller, null,
cmd.getAccountName(), cmd.getProjectId(), permittedAccounts,
domainIdRecursiveListProject, listAll, false);
+ Long projectId = cmd.getProjectId();
+ if (resourceType.equalsIgnoreCase("project") && projectId == null) {
+ projectId = Long.parseLong(resourceId);
Review comment:
yes @ustcweizhou but the search parameter is always Long, so we'll have to
either refuse it if it is a uuid or add a different search. right now an
exception is thrown.
I am thinkin g of abandoning this and just fix the test by setting the
projectId in marvin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
