gildegoma commented on issue #3388: User timezone is forced to UTC when user.timezone is undefined URL: https://github.com/apache/cloudstack/issues/3388#issuecomment-501876149 @DaanHoogland I have no preference for one solution over the other one, but I wanted to report and address the following points: 1. This new behaviour was _silently_ introduced in 4.11.0.0. (This change was not part of CLOUDSTACK-10129 [initial] goals, as far as I understood) 1. What are the exact benefits of this new behaviour? 1. If this new behaviour is kept in the future, I'd propose to consider following anti-"technical debt" actions: - [ ] Make the `user.timezone` database field explicitly mandatory (i.e. NOT NULL constraint + default value) instead of the current `UserAccountVO::getTimezone()` override hack - [ ] Remove the obsolete/unused Client-Side code (fetching browser timezone offset, etc.) - [ ] Add spec/test coverage
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
