andrijapanicsb commented on a change in pull request #3344: [WIP DO NOT MERGE] 
server: return usage description with resource names and UUIDs
URL: https://github.com/apache/cloudstack/pull/3344#discussion_r295482181
 
 

 ##########
 File path: 
api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java
 ##########
 @@ -81,6 +82,10 @@
     @Parameter(name = ApiConstants.INCLUDE_TAGS, type = CommandType.BOOLEAN, 
description = "Flag to enable display of Tags for a resource")
     private Boolean includeTags;
 
+    @Parameter(name = ApiConstants.OLD_FORMAT, type = CommandType.BOOLEAN, 
description = "Flag to enable description rendered in old format with no 
processing")
 
 Review comment:
   1. old behaviour should be the default, unless the documentation is 
(somewhere...) updated.
   2. word "processing" - does this mean that there will be additional CPU 
usage and DB hammering on top of existing (I know some people's usage_jobs 
taking many hours to complete - would like to understand performance 
consequences)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to