ustcweizhou commented on a change in pull request #3319: Use IDE as the bus
type for root disks and VIRTIO for data disks when platform emulator strings
start with Windows* except Windows PV
URL: https://github.com/apache/cloudstack/pull/3319#discussion_r301563539
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -3198,12 +3202,15 @@ public boolean isCentosHost() {
return DiskDef.DiskBus.IDE;
} else if (platformEmulator.startsWith("Other PV Virtio-SCSI")) {
return DiskDef.DiskBus.SCSI;
- } else if (platformEmulator.startsWith("Ubuntu") ||
platformEmulator.startsWith("Fedora 13") || platformEmulator.startsWith("Fedora
12") || platformEmulator.startsWith("Fedora 11") ||
- platformEmulator.startsWith("Fedora 10") ||
platformEmulator.startsWith("Fedora 9") || platformEmulator.startsWith("CentOS
5.3") || platformEmulator.startsWith("CentOS 5.4") ||
- platformEmulator.startsWith("CentOS 5.5") ||
platformEmulator.startsWith("CentOS") || platformEmulator.startsWith("Fedora")
||
- platformEmulator.startsWith("Red Hat Enterprise Linux 5.3") ||
platformEmulator.startsWith("Red Hat Enterprise Linux 5.4") ||
- platformEmulator.startsWith("Red Hat Enterprise Linux 5.5") ||
platformEmulator.startsWith("Red Hat Enterprise Linux 6") ||
platformEmulator.startsWith("Debian GNU/Linux") ||
- platformEmulator.startsWith("FreeBSD 10") ||
platformEmulator.startsWith("Oracle") || platformEmulator.startsWith("Other
PV")) {
+ } else if (platformEmulator.startsWith("Ubuntu") ||
+ platformEmulator.startsWith("Fedora") ||
+ platformEmulator.startsWith("CentOS") ||
+ platformEmulator.startsWith("Red Hat Enterprise Linux") ||
+ platformEmulator.startsWith("Debian GNU/Linux") ||
+ platformEmulator.startsWith("FreeBSD") ||
+ platformEmulator.startsWith("Oracle") ||
+ platformEmulator.startsWith("Windows PV") ||
Review comment:
@svenvogel yes, we do not need "Windows PV" in the line.
the platformEmulator is "Other PV" when guest os is "Windows PV".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
