[GitHub] [cloudstack] shwstppr opened a new pull request #3545: ui: fix for custom constrained offering params range check

[GitBox]

shwstppr opened a new pull request #3545: ui: fix for custom constrained 
offering params range check
URL: https://github.com/apache/cloudstack/pull/3545
 
 
   ## Description
   This PR fixes range check in VM deployment wizard while using custom 
constrained offering.
   Existing code was failing while checking user input value in the form for 
CPU cores and RAM size when minimum and maximum value vary in digit count.
   Also, while re-selecting offerings slider position was not restored to 
minimum value. THis has been fixed with changes.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Entering a valid value for RAM but getting error,
   
![thumbnail_image001](https://user-images.githubusercontent.com/153340/62615307-a8025180-b92a-11e9-8760-0e13e2b3bfc1.png)
   
![thumbnail_image002](https://user-images.githubusercontent.com/153340/62615308-a89ae800-b92a-11e9-86f0-070113d597c0.png)
   
   Selecting custom constrained offering initially, then making changes for 
CPU, RAM parameters, then selecting a fixed offering and then again selecting 
custom constrained offering. Though text input shows minimum values but slider 
is not at the start.
   
![thumbnail_image004](https://user-images.githubusercontent.com/153340/62615310-a9337e80-b92a-11e9-90eb-8ccd7b4248b9.png)
   
![thumbnail_image005](https://user-images.githubusercontent.com/153340/62615312-a9337e80-b92a-11e9-9b08-694ab4bc6566.png)
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to 
-->
   <!-- see how your change affects other areas of the code, etc. -->
   UI
   
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services