weizhouapache edited a comment on issue #3179: Redundant VRouter guest network 
on wrong interface
URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-554395688
 
 
   @DennisKonrad 
   I did not see any IpAssocVpcCommand  in management server log, so I think 
all are IpAssocCommand , even when ip is associated to a VPC. Please correct me 
if I am wrong
   
   We have seen and fixed many issues with VPC & RvRs in cloudstack 4.7.1, 
especially when there are multiple public ip ranges.
   For example, network element should not be cleaned up when de-associate a 
public ip.
   
https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L377-L382
   If  IP is associated/de-associated to an isolated network, the command 
should be IpAssocCommand 
   If  IP is associated/de-associated to a VPC, the command should be 
IpAssocVpcCommand 
   
   the second function
   ```prepareNetworkElementCommand(final IpAssocVpcCommand cmd)```
   does NOT work for normal setup (linux bridge), if we apply the change in 
https://github.com/apache/cloudstack/issues/3179#issuecomment-552463825
   as you said in 
https://github.com/apache/cloudstack/issues/3179#issuecomment-553641686
   
   I have changed the first function to similar behavior as the second 
function. I got the same issue as the description (source nat ip on eth2, but 
no ip on eth1). Now I can conclude that the issue is a regression issue after 
#2304, but the root cause should be wrong mac address of public ip addresses.
   
https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/router/CommandSetupHelper.java#L812-L814
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to