svenvogel commented on a change in pull request #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#discussion_r347296588
########## File path: scripts/storage/secondary/createtmplt.sh ########## @@ -210,7 +210,6 @@ echo "filename=$tmpltname" > /$tmpltfs/template.properties echo "description=$descr" >> /$tmpltfs/template.properties # we need to rethink this property as it might get changed after download due to decompression # option is to recalcutate it here -echo "checksum=$cksum" >> /$tmpltfs/template.properties Review comment: in my first PR i tried to remove the "createtmplt.sh" file completely from creation but it is "ugly" in java code used. by this way i found an not used variable. i think checksum calculation was removed from Dan Hoogland #2246. it was forgotten. i can make a separate PR if this is better? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
