pavanaravapalli commented on a change in pull request #3638: WIP: UEFI Support
on CloudStack
URL: https://github.com/apache/cloudstack/pull/3638#discussion_r348486126
##########
File path:
api/src/main/java/org/apache/cloudstack/api/response/HostResponse.java
##########
@@ -495,6 +500,14 @@ public void setDetails(Map details) {
detailsCopy.remove("username");
detailsCopy.remove("password");
+ if(detailsCopy.containsKey(Host.HOST_UEFI_ENABLE)) {
+ this.setUefiCapabilty(Boolean.parseBoolean((String)
detailsCopy.get(Host.HOST_UEFI_ENABLE)));
+ detailsCopy.remove(Host.HOST_UEFI_ENABLE);
+ } else {
+ this.setUefiCapabilty(new Boolean(false)); // in case of existing
host which is not scanned for UEFI capability
Review comment:
Yes, this is for hosts which are already existed in CloudStack. Auto
discover Uefi capability for existing host is planned as part enhancement to
this feature. Can be addressed later. Hence it's set false in initial version
of implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
