andrijapanicsb edited a comment on issue #3710: [Work in progress - do not 
merge] Replace builtin CentOS 5.x with 8.0 templates
URL: https://github.com/apache/cloudstack/pull/3710#issuecomment-557932820
 
 
   I need "help" confirming that I've done the proper job of removing an 
ancient template "centos53-x86_64" for Xen which was added in ACS 2.2 and then 
marked as  removed in ACS 4.5 - this is purely cleanup so we can more easily 
observe those builtin ones in the vm_templates table (I've issues with garbage 
collection as you can tell....)
   - I've added the delete SQL statement for schema upgrade cleanup file from 
4.13 to 4.14 - that is fine for sure
   - I've removed 2 lines from the setup/db/templates.sql - so that the 
template is NOT added in the first place for the new installations on master 
(to be 4.14) - this one is what I would like someone to confirm is OK.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to