rhtyd commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r350853257
########## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ########## @@ -268,19 +268,7 @@ public static String getDefaultEthDevice() { final String defDev = Script.runSimpleBashScript("/sbin/route -n get default 2> /dev/null | grep interface | awk '{print $2}'"); return defDev; } - final String defaultRoute = Script.runSimpleBashScript("/sbin/route | grep default"); - - if (defaultRoute == null) { - return null; - } - - final String[] defaultRouteList = defaultRoute.split("\\s+"); - - if (defaultRouteList.length != 8) { - return null; - } - - return defaultRouteList[7]; + return Script.runSimpleBashScript("ip route show default 0.0.0.0/0 | head -1 | awk '{print $5}'"); Review comment: @wido @DaanHoogland while the `/proc` subsystem is stable enough, I've used iproute now - how about now ^^ ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services