DaanHoogland commented on a change in pull request #3748: Systemvm template api
(WIP)
URL: https://github.com/apache/cloudstack/pull/3748#discussion_r355443539
##########
File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java
##########
@@ -2229,7 +2229,7 @@ private void updateTemplate(long templateId, String
fileExtension, long zoneId,
VMTemplateVO template = _tmpltDao.findById(templateId);
templateStore.setDownloadState(Status.DOWNLOADED);
templateStore.setState(ObjectInDataStoreStateMachine.State.Ready);
- templateStore.setInstallPath("template/tmpl/1/" + templateId + "/" +
template.getUuid() + "." + fileExtension);
+ templateStore.setInstallPath("template/tmpl/2/" + templateId + "/" +
template.getUuid() + "." + fileExtension);
Review comment:
in a method called 'updateTemplate(...)' a hardcoded path like this is very
suspect. Did you name the method correctly? it seems we need to give a more
descriptive/restrictive/deterring name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
