anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358708732
########## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ########## @@ -658,7 +685,21 @@ public boolean start() { if (routerAlertsCheckInterval > 0) { _checkExecutor.scheduleAtFixedRate(new CheckRouterAlertsTask(), routerAlertsCheckInterval, routerAlertsCheckInterval, TimeUnit.SECONDS); } else { - s_logger.debug("router.alerts.check.interval - " + routerAlertsCheckInterval + " so not scheduling the router alerts checking thread"); + s_logger.debug(RouterAlertsCheckIntervalCK + "=" + routerAlertsCheckInterval + " so not scheduling the router alerts checking thread"); + } + + final int routerHealthCheckDataRefreshInterval = RouterHealthChecksDataRefreshInterval.value(); + if (routerHealthCheckDataRefreshInterval > 0) { + _checkExecutor.scheduleAtFixedRate(new UpdateRouterHealthChecksConfigDataTask(), routerHealthCheckDataRefreshInterval, routerHealthCheckDataRefreshInterval, TimeUnit.MINUTES); + } else { + s_logger.debug(RouterHealthChecksDataRefreshIntervalCK + "=" + routerAlertsCheckInterval + " so not scheduling the router health check data thread"); Review comment: Errr... mistake. fixing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services