DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360386594
########## File path: plugins/user-authenticators/ldap/pom.xml ########## @@ -81,38 +86,126 @@ <include>**/*Spec.groovy</include> <include>**/*Test.java</include> </includes> + <excludes> + <exclude>META-INF/*.SF</exclude> + <exclude>META-INF/*.DSA</exclude> + <exclude>META-INF/*.RSA</exclude> + </excludes> </configuration> </plugin> <plugin> <groupId>com.btmatthews.maven.plugins</groupId> <artifactId>ldap-maven-plugin</artifactId> - <version>1.1.0</version> + <version>1.1.3</version> <configuration> <monitorPort>11389</monitorPort> <monitorKey>ldap</monitorKey> <daemon>false</daemon> <rootDn>dc=cloudstack,dc=org</rootDn> <ldapPort>10389</ldapPort> - <ldifFile>test/resources/cloudstack.org.ldif</ldifFile> + <ldifFile>src/test/resources/cloudstack.org.ldif</ldifFile> </configuration> </plugin> </plugins> - <testSourceDirectory>test</testSourceDirectory> + <testSourceDirectory>src/test/java</testSourceDirectory> </build> <dependencies> <!-- Mandatory dependencies for using Spock --> + <dependency> + <groupId>com.btmatthews.ldapunit</groupId> + <artifactId>ldapunit</artifactId> + <version>1.1.3</version> Review comment: Pulling the global ones from the top level pom and the local ones that are test specific only in the local properties section. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services